The script's first command was `sudo apt-get update` under `set -euo
pipefail`. On a system with a broken InfluxData repo, that command exits
100, so the script aborted at line 7 and never reached the InfluxData key
repair further down. The repair code could not run on exactly the systems
it existed to fix.
- Reorder: fetch and install keys before the first apt-get update.
- Drop -e so a failed update cannot abort key repair.
- Verify the fetched key's fingerprint before installing it; a mismatch is
no longer installed after a warning.
- Reuse an existing keyring only if it contains the correct fingerprint;
delete a stale/wrong keyring so it is refetched.
- Remove the [trusted=yes] fallback, which silently disabled signature
verification. If no verifiable key is available, disable the repo
instead.
- Detect VERSION_CODENAME for the Sury source instead of hardcoding
bookworm, so trixie hosts get a valid suite.
- Fail loudly with the apt error if update still fails after repair.
- updates.sh: use BASH_SOURCE to find script dir, so fix_apt_influx.sh
can be called from anywhere (was failing with 'command not found' when
run from outside the updates_scripts directory)
- fix_apt_influx.sh: if key download fails but keyring already exists on
disk, reuse it with [signed-by=] instead of falling back to
[trusted=yes] which disables signature verification entirely
- Fixes: Missing key AC10D7449F343ADCEFDDC2B6DA61C26A0585BD3B error
on Trixie when running updates.sh
* Fix InfluxDB APT key: add fallback sources and trusted=yes fallback
The key URL at repos.influxdata.com/influxdata-archive.key is intermittently
down. Add keyserver.ubuntu.com as fallback source. Use trusted=yes as last
resort if key fetch fails. Also correct keyring path to /usr/share/keyrings/
and remove Bookworm-specific comment.
* Fix shellcheck issues: remove duplicate shebang, fix cd error handling
---------
Co-authored-by: Jarvis <jarvis@wickedyoda.local>