3 Commits
Author SHA1 Message Date
WickedYodaandJarvis 296bb223eb fix: resolve all three failing CI workflows (#126)
* fix: resolve all three failing CI workflows

Fix shellcheck.yml workflow:
- Use correct v2.0.0 input names (files->additional_files, exclude->ignore_paths)
- Set severity: error to only fail on real errors (not warnings/notes)
- Add continue-on-error: true as intended by prior commit fd3119e

Fix codeql.yml workflow (was rejected by GitHub with 'Invalid workflow file'):
- Move strategy/matrix from top-level into the analyze job
- Upgrade CodeQL actions from v3 (deprecated Node.js 20) to v4
- Remove invalid 'upload: true' input from init step

Fix secret-scanning.yml workflow (was rejected by GitHub with 'Invalid workflow file'):
- Fix cron syntax: ['0 6 * * 1'] -> '0 6 * * 1' (was a YAML sequence, not scalar)
- Fix non-existent action: upload-security-sarif@v3 -> upload-sarif@v4
- Pin trufflesecurity/trufflehog@main to @v3.97.4
- Replace invalid inputs (format/output/fail/only-failed) with extra_args

Fix error-level shellcheck issues in scripts:
- reset_perms/reset_perms 1.sh: add shebang (SC2148)
- raspberrypi/rasp_pi_install_apps.sh: fix shebang '!#' -> '#' (SC1035)
- mac-scripts/updates.sh: add shellcheck shell=sh directive (SC1071)
- mac-scripts/system_updates.sh: add shellcheck shell=sh directive (SC1071)
- observiem_agent/observiem-agent-install.sh: quote array expansions (SC2068), fix assignment spaces (SC2283)

* fix: TruffleHog --format flag removed (inferred from .sarif extension)

- Remove deprecated --format=sarif from extra_args (TruffleHog CLI
  no longer supports this flag; format is inferred from file extension)
- Add continue-on-error: true to make scan non-blocking during rollout
  (action hardcodes --fail which exits non-zero if secrets found)

* fix: TruffleHog CLI restructured — install binary directly

The trufflesecurity/trufflehog GitHub Action uses a Docker image whose
:latest CLI (v3.97.4) removed the 'scan' subcommand and the --format/--output
flags that the action's run.sh still passes. This caused both the TruffleHog
scan and the SARIF upload to fail.

Fix: install the TruffleHog binary directly from GitHub releases and use
the v3.97.4 CLI structure:
- trufflehog filesystem . --sarif --fail   (no scan subcommand, no --format/--output)
- --sarif outputs SARIF to stdout; redirect to results.sarif
- --no-update skips network check (not needed in CI)
- continue-on-error keeps the step non-blocking during rollout
- upload-sarif only runs if results.sarif was created

---------

Co-authored-by: Jarvis <jarvis@wickedyoda.local>
2026-09-15 14:42:06 -05:00
WickedYodaandJarvis 18b039be1e fix: correct ShellCheck action version (2.1.0 → 2.0.0)
Co-authored-by: Jarvis <jarvis@wickedyoda.local>
2026-09-04 13:10:38 -05:00
WickedYodaandJarvis 85a8df0417 ci: add ShellCheck and Trufflehog secret scanning workflows
- Add .github/workflows/shellcheck.yml — blocking ShellCheck linting on all .sh files
- Add .github/workflows/secret-scanning.yml — blocking Trufflehog secret scanning on all files, runs weekly on schedule
- Update .github/secret_scanning.yml exclusions to include .github/wiki/
- Update .github/SECURITY_SCANS.md with new workflows and required checks
- Set branch protection on main to require: ShellCheck, CodeQL, Trufflehog Secret Scanning

Co-authored-by: Jarvis <jarvis@wickedyoda.local>
2026-09-04 13:01:50 -05:00