mirror of
https://github.com/wickedyoda/public-setupfiles.git
synced 2026-11-16 13:31:56 -06:00
fix: resolve all three failing CI workflows (#126)
* fix: resolve all three failing CI workflows
Fix shellcheck.yml workflow:
- Use correct v2.0.0 input names (files->additional_files, exclude->ignore_paths)
- Set severity: error to only fail on real errors (not warnings/notes)
- Add continue-on-error: true as intended by prior commit fd3119e
Fix codeql.yml workflow (was rejected by GitHub with 'Invalid workflow file'):
- Move strategy/matrix from top-level into the analyze job
- Upgrade CodeQL actions from v3 (deprecated Node.js 20) to v4
- Remove invalid 'upload: true' input from init step
Fix secret-scanning.yml workflow (was rejected by GitHub with 'Invalid workflow file'):
- Fix cron syntax: ['0 6 * * 1'] -> '0 6 * * 1' (was a YAML sequence, not scalar)
- Fix non-existent action: upload-security-sarif@v3 -> upload-sarif@v4
- Pin trufflesecurity/trufflehog@main to @v3.97.4
- Replace invalid inputs (format/output/fail/only-failed) with extra_args
Fix error-level shellcheck issues in scripts:
- reset_perms/reset_perms 1.sh: add shebang (SC2148)
- raspberrypi/rasp_pi_install_apps.sh: fix shebang '!#' -> '#' (SC1035)
- mac-scripts/updates.sh: add shellcheck shell=sh directive (SC1071)
- mac-scripts/system_updates.sh: add shellcheck shell=sh directive (SC1071)
- observiem_agent/observiem-agent-install.sh: quote array expansions (SC2068), fix assignment spaces (SC2283)
* fix: TruffleHog --format flag removed (inferred from .sarif extension)
- Remove deprecated --format=sarif from extra_args (TruffleHog CLI
no longer supports this flag; format is inferred from file extension)
- Add continue-on-error: true to make scan non-blocking during rollout
(action hardcodes --fail which exits non-zero if secrets found)
* fix: TruffleHog CLI restructured — install binary directly
The trufflesecurity/trufflehog GitHub Action uses a Docker image whose
:latest CLI (v3.97.4) removed the 'scan' subcommand and the --format/--output
flags that the action's run.sh still passes. This caused both the TruffleHog
scan and the SARIF upload to fail.
Fix: install the TruffleHog binary directly from GitHub releases and use
the v3.97.4 CLI structure:
- trufflehog filesystem . --sarif --fail (no scan subcommand, no --format/--output)
- --sarif outputs SARIF to stdout; redirect to results.sarif
- --no-update skips network check (not needed in CI)
- continue-on-error keeps the step non-blocking during rollout
- upload-sarif only runs if results.sarif was created
---------
Co-authored-by: Jarvis <jarvis@wickedyoda.local>
This commit is contained in:
1 parent
81dc71c6d5
commit
296bb223eb
8 files changed
+40
-37
No files matched your search
@@ -16,7 +16,7 @@ if [ -z "$PKG_MANAGERS" ] || [ ${#PKG_MANAGERS[@]} -eq 0 ]; then
|
||||
echo "Error! No package managers specified"
|
||||
exit 1
|
||||
else
|
||||
for pkg in ${PKG_MANAGERS[@]}; do
|
||||
for pkg in "${PKG_MANAGERS[@]}"; do
|
||||
TEST=`which $pkg`
|
||||
if [ $? -eq 0 ]; then
|
||||
PKG_MAN=$pkg
|
||||
@@ -51,7 +51,7 @@ if [ -z "$OBSERVIUM_HOST" ]; then
|
||||
fi
|
||||
|
||||
if [ -z "$SVN_USER" ] || [ -z "$SVN_PASS" ]; then
|
||||
$ENTERPRISE = false
|
||||
ENTERPRISE=false
|
||||
fi
|
||||
|
||||
if [ "$ENTERPRISE" = true ]; then
|
||||
@@ -127,7 +127,7 @@ mkdir -p /usr/lib/observium_agent/local
|
||||
if [ -z "$MODULES" ] || [ ${#MODULES[@]} -eq 0 ]; then
|
||||
echo "No modules specified skipping..."
|
||||
else
|
||||
for mod in ${MODULES[@]}; do
|
||||
for mod in "${MODULES[@]}"; do
|
||||
cp observium/scripts/agent-local/$mod /usr/lib/observium_agent/local/
|
||||
done
|
||||
fi
|
||||
|
||||
Reference in new issue
Block a user