fix: resolve all three failing CI workflows (#126)

* fix: resolve all three failing CI workflows

Fix shellcheck.yml workflow:
- Use correct v2.0.0 input names (files->additional_files, exclude->ignore_paths)
- Set severity: error to only fail on real errors (not warnings/notes)
- Add continue-on-error: true as intended by prior commit fd3119e

Fix codeql.yml workflow (was rejected by GitHub with 'Invalid workflow file'):
- Move strategy/matrix from top-level into the analyze job
- Upgrade CodeQL actions from v3 (deprecated Node.js 20) to v4
- Remove invalid 'upload: true' input from init step

Fix secret-scanning.yml workflow (was rejected by GitHub with 'Invalid workflow file'):
- Fix cron syntax: ['0 6 * * 1'] -> '0 6 * * 1' (was a YAML sequence, not scalar)
- Fix non-existent action: upload-security-sarif@v3 -> upload-sarif@v4
- Pin trufflesecurity/trufflehog@main to @v3.97.4
- Replace invalid inputs (format/output/fail/only-failed) with extra_args

Fix error-level shellcheck issues in scripts:
- reset_perms/reset_perms 1.sh: add shebang (SC2148)
- raspberrypi/rasp_pi_install_apps.sh: fix shebang '!#' -> '#' (SC1035)
- mac-scripts/updates.sh: add shellcheck shell=sh directive (SC1071)
- mac-scripts/system_updates.sh: add shellcheck shell=sh directive (SC1071)
- observiem_agent/observiem-agent-install.sh: quote array expansions (SC2068), fix assignment spaces (SC2283)

* fix: TruffleHog --format flag removed (inferred from .sarif extension)

- Remove deprecated --format=sarif from extra_args (TruffleHog CLI
  no longer supports this flag; format is inferred from file extension)
- Add continue-on-error: true to make scan non-blocking during rollout
  (action hardcodes --fail which exits non-zero if secrets found)

* fix: TruffleHog CLI restructured — install binary directly

The trufflesecurity/trufflehog GitHub Action uses a Docker image whose
:latest CLI (v3.97.4) removed the 'scan' subcommand and the --format/--output
flags that the action's run.sh still passes. This caused both the TruffleHog
scan and the SARIF upload to fail.

Fix: install the TruffleHog binary directly from GitHub releases and use
the v3.97.4 CLI structure:
- trufflehog filesystem . --sarif --fail   (no scan subcommand, no --format/--output)
- --sarif outputs SARIF to stdout; redirect to results.sarif
- --no-update skips network check (not needed in CI)
- continue-on-error keeps the step non-blocking during rollout
- upload-sarif only runs if results.sarif was created

---------

Co-authored-by: Jarvis <jarvis@wickedyoda.local>
This commit is contained in:
WickedYodaandJarvis authored and GitHub committed 2026-09-15 14:42:06 -05:00
1 parent 81dc71c6d5
commit 296bb223eb
8 files changed
+40 -37

No files matched your search

+5 -5
View File
@@ -18,14 +18,14 @@ jobs:
uses: actions/checkout@v4
- name: Run ShellCheck on all shell scripts
# Non-blocking during initial rollout phase — set to false to make it gating
continue-on-error: true
uses: ludeeus/action-shellcheck@2.0.0
with:
# Check all .sh files, excluding .git and vendor directories
files: |
*.sh
**/*.sh
# Only fail on error-level issues (not warnings, info, or style)
severity: error
# Exclude directories we don't want to lint
exclude: |
ignore_paths: |
.git
.idea
.vscode